nimforum mirror - Am I allowed to add this feature to stdlib module?

Niminem (orginal) [2022-01-05T22:48:17+01:00] view original

Part of my work involves documenting and fixing 30X redirect chains for websites. For the longest time I've just been using Python, it allows me to get the "history" of a request as it makes its jump from URL to URL.

Inspired by Python's capability, I've modified the Response type within the std/httpclient module to include a "history" property. This contains a sequence of tuples (url: string, code: HttpCode). When the request procedure is called, this property is updated with each redirect.

Can I add this feature to the stdlib?

PMunch (orginal) [2022-01-06T08:53:05+01:00] view original

If you've already written the code just make a PR to the repository and the discussion can be had there as usual.

Araq (orginal) [2022-01-06T18:06:49+01:00] view original

Sounds like a logical memory leak to me. Usually libraries work better when they don't log/track everything.

Niminem (orginal) [2022-01-08T18:30:57+01:00] view original

Thanks guys, are there prerequisites for PRs to Nim lang? Do I need to add a test for this or is documentation code enough?

DeletedUser (orginal) [2022-01-08T19:14:58+01:00] view original

You can ref https://github.com/nim-lang/Nim/pull/16691 and https://github.com/nim-lang/Nim/pull/18738

Mirror of forum.nim-lang.org

8778 :: Am I allowed to add this feature to stdlib module?