Mirror of forum.nim-lang.org

5678 :: Contributing to standard library

• mp035 (orginal) [2019-12-13T00:30:14+01:00] view original

  Hi, I recently assisted with some changes to the fantastic serial.nim project by euantorano. Part of my contribution required including a modified version of the windows registry module with 2 extra bits of functionality:

  iterator enumKeyValues*(path: string, handle: HKEY): tuple[key:string, value:string] =
  # to retreive all name/value pairs from a registry key.
  
  proc getDwordValue*(path, key: string; handle: HKEY): int32 =
  # to get a numeric value from the registry
  Run

  The project author suggested that the iterator would be useful in the standard library, and I often need to read numeric values from the registry, so I was wondering, what is the correct way to see if these functions can be included in the standard library?

  I'm happy to submit a PR for review, which doesn't break backward compatibility.

---

• Araq (orginal) [2019-12-13T10:46:11+01:00] view original

  A couple of patterns emerged:

  • Stdlib procs must have tests, in this case Windows specific tests are fine.
  • New routines should be annotated with .since: (1, 1)
  • We have to be capable of maintaining it for a long time.
  • New modules should be introduced as Nimble packages.

  In your case, please go for it and create a PR as it's small enough.

---

• treeform (orginal) [2019-12-13T19:01:37+01:00] view original

  I also feel like a ton of windows work has gone into the https://github.com/khchen/winim library. I would use winim for any serous windows specific work. It supports way more windows APIs and has a better interface in many cases.

---