Mirror of forum.nim-lang.org

5461 :: Disabling unused import warning locally

• andrea (orginal) [2019-11-05T10:51:45+01:00] view original

  I frequently write test suites in different files. Then I have a main test file which imports all suites. One example from emmy <https://github.com/unicredit/emmy>_ looks like this:

  import tstructures, tpairs, toperations, ttableops, tmodular, tfractions,
    tpolynomials, tlinear, tprimality, tintegers_modulo, tfinite_fields,
    tnormal_forms
  Run

  The problem is that I get a lot of warnings like

  
  /Users/andrea/progetti/emmy/tests/all.nim(16, 8) Warning: imported and not used: 'tstructures' [UnusedImport]
  /Users/andrea/progetti/emmy/tests/all.nim(16, 21) Warning: imported and not used: 'tpairs' [UnusedImport]
  /Users/andrea/progetti/emmy/tests/all.nim(16, 29) Warning: imported and not used: 'toperations' [UnusedImport]
  /Users/andrea/progetti/emmy/tests/all.nim(16, 42) Warning: imported and not used: 'ttableops' [UnusedImport]
  /Users/andrea/progetti/emmy/tests/all.nim(16, 53) Warning: imported and not used: 'tmodular' [UnusedImport]
  /Users/andrea/progetti/emmy/tests/all.nim(16, 63) Warning: imported and not used: 'tfractions' [UnusedImport]
  /Users/andrea/progetti/emmy/tests/all.nim(17, 3) Warning: imported and not used: 'tpolynomials' [UnusedImport]
  /Users/andrea/progetti/emmy/tests/all.nim(17, 17) Warning: imported and not used: 'tlinear' [UnusedImport]
  /Users/andrea/progetti/emmy/tests/all.nim(17, 26) Warning: imported and not used: 'tprimality' [UnusedImport]
  /Users/andrea/progetti/emmy/tests/all.nim(17, 38) Warning: imported and not used: 'tintegers_modulo' [UnusedImport]
  /Users/andrea/progetti/emmy/tests/all.nim(17, 56) Warning: imported and not used: 'tfinite_fields' [UnusedImport]
  /Users/andrea/progetti/emmy/tests/all.nim(18, 3) Warning: imported and not used: 'tnormal_forms' [UnusedImport]
  Run

  I tried to locally disable the warning by thi small modification

  {. warning[UnusedImport]:off .}
  import tstructures, tpairs, toperations, ttableops, tmodular, tfractions,
    tpolynomials, tlinear, tprimality, tintegers_modulo, tfinite_fields,
    tnormal_forms
  {. warning[UnusedImport]:on .}
  Run

  but apparently it has no effect. What is the correct incantation to persuade the compiler to not give warnings for these imports?

---

• Araq (orginal) [2019-11-05T11:15:37+01:00] view original

  1. I hope we can make your push/pop snippet work. It should work.
  2. I would use the following code in all of your t*.nim files:

  when defined(nimHasUsed):
    {.used.}
  
  Run

---

• cdome (orginal) [2019-11-05T12:18:39+01:00] view original

  I am having this problem too. Push/Pop doesn' work if there is an import in between then. There is PR by myself that I need to finish to make it work: https://github.com/nim-lang/Nim/issues/11826.

---

• yglukhov (orginal) [2019-11-06T16:42:16+01:00] view original

  Another way is to fix the unused warning, so that it pops up whenever no symbols are used from the imported module and the imported module has no global code with side effects (and it should be a recursive check).

---

• Levlan (orginal) [2019-11-06T18:21:56+01:00] view original

  Never mind. I just moved the extracted folder to C:main directory and run again finish.exe.

  Happy nimming to all of you.

---

• cdome (orginal) [2019-11-07T18:54:54+01:00] view original

  Fix went in. {. warning[UnusedImport]:off .}` works now, but it needs to be active at the end of module as this is where the check is happening

---

• andrea (orginal) [2019-11-08T16:25:25+01:00] view original

  Great, thank you

---