Mirror of forum.nim-lang.org

2488 :: asynchttpserver and big request body

• vega (orginal) [2016-08-24T08:46:10+02:00] view original

  Request body is readed in memory at once. So, we can't receive big POST requests. Maybe we can introduce new type, RequestBody, that can be used to get body as a string/file/stream/whatever, or maybe even handle application/x-www-form-urlencoded or multipart/form-data mime types?

---

• dom96 (orginal) [2016-08-24T18:06:27+02:00] view original

  Please create an issue for this.

---

• _tulayang (orginal) [2016-08-25T03:37:41+02:00] view original

  Suggest to export the data received at each time, so that users can use this api to customize how their datas are stored (copy to their buffer or disk files).

---

• vega (orginal) [2016-08-25T05:08:20+02:00] view original

  I created the fork of asynchttpserver for the test: https://github.com/vegansk/asynchttpserver2 where you can read entire body using request.body.readAll, get the length of the request without reading it via request.body.len. And the main feature - you can read it via stream: request.body.getStream.

  And the latter method is bothering me. asynchttpserver is async, standard streams are not. Thats why I want to write asyncstreams module for the standard library. What do you think about it?

---

• dom96 (orginal) [2016-08-25T09:04:37+02:00] view original

  Thats why I want to write asyncstreams module for the standard library. What do you think about it?

  Sounds like a good idea :)

---

• vega (orginal) [2016-08-25T13:06:28+02:00] view original

  WIP is here: https://github.com/vegansk/asyncstreams

---

• _tulayang (orginal) [2016-08-25T16:43:58+02:00] view original

  @vega

  I think it is different between io of httpserver and stand stream. readChar readData ... are not useful. I think we need apis like recvOnClientError recvOnAChunk recvOn100Continue recvOnTimeout etc.

---

• vega (orginal) [2016-08-26T04:16:52+02:00] view original

  @_tulayang, I think that asyncstreams must implement generic streams, not http. And API that you suggest can be implemented in asynchttpserver or another http related module, but not in generic streams.

  More opinions?

---

• Varriount (orginal) [2016-08-27T15:49:49+02:00] view original

  I'd love interfaces like the ones shown by requests and unirest...

---

• dom96 (orginal) [2016-08-27T15:51:41+02:00] view original

  Yes, I think it should implement a generic stream. You can have more than just async sockets, async files are a thing too and you can map the API of sockets fairly well onto this generic streams API.

---