nimforum mirror - How to create a pull request?

HJarausch (orginal) [2021-04-17T11:24:48+02:00] view original

I have clone nim into github/HJarausch/Median. There I have modified some files. How can I create a pull request now? Many thanks for a hint, Helmut

haxscramper_ (orginal) [2021-04-17T12:03:07+02:00] view original

Just as you would create PR in any other GitHub repository - https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request

HJarausch (orginal) [2021-04-17T12:48:08+02:00] view original

Sorry, I haven't done that before.

If I try to create a pull request, I get the compare changes page. But on this page I cannot select my repository though I have created it by clone Nim/devel.

Thanks for a help hand, Helmut

pietroppeter (orginal) [2021-04-17T13:17:26+02:00] view original

In order to create a PR for Nim you need to fork it, it is not enough to clone and modify it.

You can follow this guide: https://www.freecodecamp.org/news/how-to-make-your-first-pull-request-on-github-3/

Steps are:

Fork (from GitHub)

Clone the fork (locally)

Create a new branch (e.g. git checkout -b add-median)

Do modifications in the branch, commit and push

You should be able to see in GitHub a message about your branch being recently pushed and a shortcut to create a PR from that branch)

HJarausch (orginal) [2021-04-17T17:38:53+02:00] view original

Many thanks pietroppeter. I managed to create my first PR now.

Mirror of forum.nim-lang.org

7808 :: How to create a pull request?