Mirror of forum.nim-lang.org

6857 :: Nimpretty --maxLineLine seems broken

• Clonk (orginal) [2020-09-25T14:36:30+02:00] view original

  Hello,

  I recentry used nimpretty --maxLineLen:120 to override the 80 default value and it seems it's not doing anything.

  I still have the same Hint: line too loog for line over 80 character. Is there something I missed in Nimpretty usage or is this option not working as intended ?

---

• Araq (orginal) [2020-09-25T16:03:08+02:00] view original

  I think Nim's lexer produces the warning and is used by nimpretty. Disable via --hint[LineTooLong]:off.

---

• timothee (orginal) [2020-09-25T19:52:05+02:00] view original

  or even better, allow customizing the hardcoded value of 80 and make all such references to it point to that configurable value

---

• Clonk (orginal) [2020-09-25T20:28:49+02:00] view original

  The problem is that I'm using Nimpretty in a Vim config file as a parameters for the ALE Plugin (https://github.com/dense-analysis/ale) :

  
  let g:ale_fixers = { \
   '*': ['remove_trailing_lines', 'trim_whitespace'], \
    'nim': ['nimpretty'], \
  }
  Run

  And it automatically cut the line at 80. I could remove the formatting, I'm pretty satisfied I just wish I could increase the line length as 80 character is quite short in my opinion (I have a wide screen).

---

• cdunn2001 (orginal) [2020-10-10T05:57:14+02:00] view original

  I agree with this, but for a different reason. I have bad eyes, so I always use 80 columns in my monitor. But my editor can line-wrap.

  The problem is when a function has several parameters. If I add one in the middle, the nimpretty wrap position moves. With different changes on different branch, git diff will not show just the parameter that changed, and git merge hits snags.

  It's not a huge problem, but I agree with @timothee on the simple solution. I really like nimpretty -- for everything except line-wrapping.

---

• Araq (orginal) [2020-10-10T07:50:43+02:00] view original

  https://github.com/nim-lang/Nim/pull/15541

---