Mirror of forum.nim-lang.org

5653 :: Manual query "deviated" ?

[2019-12-07T22:12:09+01:00]

marks (orginal) [2019-12-07T22:12:09+01:00] view original
In the manual there's this example:
```
proc forward[T](x: var T): var T =
  result = x # ok, deviated from the first parameter.
```
The word deviated is also used in the text above. But these uses all seem wrong to me. I think the above comment ought to be # ok, determined from ... or # ok, determined by ..., and similarly in the text?

Araq (orginal) [2019-12-07T22:32:31+01:00] view original

It should be "derived from", I think, but then I'm the one who made the mistake to begin with...

marks (orginal) [2019-12-08T09:54:10+01:00] view original
"derived" kind of means or imlies "inherited", so if you don't like "determined by", I'd suggest one of these:
- " ok, based on the first parameter"
- " ok, based on the type of the first parameter"
- " ok, based on the first parameter's type"
Plus, of course, similar changes to the text in the preceding para.

Araq (orginal) [2019-12-08T10:37:59+01:00] view original

"derived" kind of means or implies "inherited"
Yes, so it fits, but it's not related to inheritance in the OOP sense.

But please create a PR already, then you get to decide the wording.

marks (orginal) [2019-12-08T11:52:56+01:00] view original

OK, I've done two patches (since two files needed to be changed --- I'm not much of a github user). https://github.com/nim-lang/Nim/pull/12845 https://github.com/nim-lang/Nim/pull/12846 If I see other typos or problems with English I'll try to do PRs for them in future.