Mirror of forum.nim-lang.org

4362 :: the v0.19.1 => 0.19.9 jump should've been v0.19.0 => 0.20.0

• timothee (orginal) [2018-11-07T00:54:27+01:00] view original

  this commit b4f16fab498ae705532391d7f57481197972d70f changed from 0.19.1 to 0.19.9

  this doesn't make sense to me. What would make sense would be to change from 0.19.1 to 0.20.0

  if we want to backport critical bugs to 0.19.X, they can be backported to a branch hotfix/0.19.2 until a new tag 0.19.2 is created, for example as described in the oneflow development and release model described in development and release model: use the `oneflow` model - Nim forum

  For example, recent changes (in 0.19.X) made backward incompatible changes to UncheckedArray ; with the current model, I don't know how to push a fix for https://github.com/status-im/nim-ranges/issues/30#issuecomment-436445656

  The traditional way is (ignoring NimMajor here since we're pre 1.0):

  
  when NimMinor >= 0.20:
    do fix for newer versions of Nim
  else:
    do old way compatible with 0.19.X
  Run

  however that doesn't work here since latest stable is still 0.19.0 and devel is... well, also 0.19.X (0.19.X)

  proposal

  as soon as we have a 0.x.y released (for example 0.19.0 in git tags), devel should immediately point to 0.(x+1).0 (ie, 0.20.0)

---

• miran (orginal) [2018-11-07T07:18:16+01:00] view original

  We have 1400+ open issues.

  Is the name of the devel branch (How many of total Nim users even use devel branch? How many of them care about its name?) really something we should spend our time discussing?

---

• GULPF (orginal) [2018-11-07T07:29:03+01:00] view original

  as soon as we have a 0.x.y released (for example 0.19.0 in git tags), devel should immediately point to 0.(x+1).0 (ie, 0.20.0)

  Devel isn't allowed to use the same version as a stable version, because then there's no way to know that it's a devel version. If it jumps to 0.20.0, then the next stable release would be 0.20.1, which is awkward.

---

• timothee (orginal) [2018-11-07T07:40:03+01:00] view original

  I'm not talking about the name of devel branch but about semantic versioning

  typically, symver assumptions is that patch version is increased for bug fixes; they shouldn't introduce breaking changes;

  right now devel (with NimMajor.Minor.Path = 0.19.9) keeps introducing breaking changes on the same minor version as latest released stable (0.19.0); those breaking changes should be on 0.20.x instead

---

• Araq (orginal) [2018-11-07T07:53:52+01:00] view original

  There is no "semantic versioning" as long as we have the 0.x, strictly speaking, afaict. In addition to that, we have the "odd versions are devel versions, even versions are releases" rule. And since there is no 0.20.-1``version, ``0.19.9 is the best version available.

---

• dom96 (orginal) [2018-11-07T23:59:30+01:00] view original

  I disliked it at first glance too, but honestly, I'm really starting to see the value in the little time I have left now and so I think these kinds of discussions are unnecessary.

---

• moigagoo (orginal) [2018-11-08T08:40:36+01:00] view original

  I'm really starting to see the value in the little time I have left now

  Sound scary. You ok?

---

• dom96 (orginal) [2018-11-08T14:34:47+01:00] view original

  Probably could have worded that better. I'm fine, just missing the student life :)

---