Mirror of forum.nim-lang.org

2490 :: httpclient extraHeaders not working

• demian (orginal) [2016-08-24T17:57:32+02:00] view original

  I'm trying to execute a simple request adding some headers but it fails with time-out. Here's my test code:

  import httpclient
  
  const division :string = "\c\L"
  const userAgent = "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Windows Chromium/51.0.2704.79 Chrome/51.0.2704.79 Safari/537.36"
  const headers = "Accept-Language: en-US,en;q=0.8,es;q=0.6" & division & "Connection:keep-alive"
  const url = "https://duckduckgo.com/?q=site%3Anim-lang.org+extraHeaders&t=canonical&ia=web"
  
  var content:string = getContent(url, extraheaders = headers, userAgent = userAgent)
  
  Run

  I'm compiling it with:

  
  nim c -r -d:ssl request_test.nim
  Run

  If I remove the extraHeader parameter it works well OK. Any idea what's wrong?

  Nim version: Nim Compiler Version 0.14.3 (2016-08-23) [Linux: amd64]

---

• dom96 (orginal) [2016-08-24T18:02:43+02:00] view original

  I think you might need to add another division at the end of the headers.

---

• OderWat (orginal) [2016-08-24T18:25:44+02:00] view original

  I think there need to be two of them at the end (at least if there is some body content which could even be there with GET). I also think this should be handled by the http client. And headers should be a sequence or an array instead of a "string which works if you know how".

---

• demian (orginal) [2016-08-24T19:30:30+02:00] view original

  Thank you. It worked with the "cL" at the end.

---

• dom96 (orginal) [2016-08-24T20:03:11+02:00] view original

  @OderWat: Yes, this is already the case with the AsyncHttpClient. I plan to introduce a HttpClient also which will deprecate the current synchronous API.

---

• euant (orginal) [2016-08-25T11:05:32+02:00] view original

  @dom96: That reminds me that I was going to submit a PR for that...

---