Mirror of forum.nim-lang.org

1046 :: Github guidelines

• EXetoC2 (orginal) [2015-03-17T22:07:06+01:00] view original

  I think it would be a good idea to also include a description along with "fixes #xxxx", which would save one from having to click a link in order to find out more in most cases. I only just recently saw a commit that used this format.

---

• gmpreussner (orginal) [2015-03-18T04:44:10+01:00] view original

  Agreed. "Fixes bla bla (#xxxx)" should do the trick :)

---

• Varriount (orginal) [2015-03-18T05:04:42+01:00] view original

  If I'm not mistaken, most of those messages are automatically generated. Github reads commit messages, and if it finds something like 'Fixes #845', it closes issue #845.

---

• OderWat (orginal) [2015-03-19T00:20:32+01:00] view original

  I think he is talking about the "fixes orgies" which are likely to happen when a good developer is in the "flow" :)

  Reading a commit log actually is not supposed to repeat all information if you work with an Issue System or discuss PR. That just highly redundant information in that case.

  BUT.. Wait! See this screenshot: http://snpy.link/5Ht6v4

  If you really want to now what it "fixes". Move your mouse over it .. with or without shift! This works for many places where information in GitHub is referenced. No need to click the links.

---

• EXetoC (orginal) [2015-03-19T00:44:00+01:00] view original

  I should look at that section more often, and I didn't know about the hover text.

---